Bump 7.x to 7.5 #4233
Merged
Bump 7.x to 7.5 #4233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alues are descriptions and we already have a Time type
And document them as deprecated relates: elastic/elasticsearch#47933
…rge since we temporarily still rework the spec files in memory to the old format
Mark as obsolete to warn the user but without breaking backwards compatibily. The 7.5 client should be able to be used against < 7.5 server. relates: github.com/elastic/elasticsearch/pull/47228
Mpdreamz
commented
Nov 20, 2019
| @@ -86,8 +86,6 @@ public CatAllocationDescriptor(NodeIds nodeId): base(r => r.Optional("node_id", | |||
| ///<summary>A comma-separated list of node IDs or names to limit the returned information</summary> | |||
| public CatAllocationDescriptor NodeId(NodeIds nodeId) => Assign(nodeId, (a, v) => a.RouteValues.Optional("node_id", v)); | |||
| // Request parameters | |||
| ///<summary>The unit in which to display byte values</summary> | |||
| public CatAllocationDescriptor Bytes(Bytes? bytes) => Qs("bytes", bytes); | |||
There was a problem hiding this comment.
Should not exclude bytes will do a follow up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps our
7.xover to7.5Updated code generation
Handle quirks in the spec introduced in 7.5
New
timeenum is different from common option's time, the spec includes descriptions in the values.Same problem for
bytes.localandmaster_timeoutwere removed in a minor. These were falsely documented as the server did not accept them. We add them back in obsolete fashion.Some API endpoints remove
forcefromversion_typebut not all eventhough it was removed in a minor on the server from all endpoints. We still need to keep it around though because our7.5client can also speak to7.0Elasticsearch that does still accept the parameter.